Skip to content

Move primary buttons on the right of the dialogs #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 20, 2022
Merged

Move primary buttons on the right of the dialogs #1382

merged 7 commits into from
Sep 20, 2022

Conversation

francescospissu
Copy link
Contributor

@francescospissu francescospissu commented Sep 1, 2022 •
edited
Loading

Motivation

In some dialogs, the primary button is not on the right.

Change description

Move all primary buttons in dialogs to the right.

Screenshot 2022-09-01 142402

Screenshot 2022-09-01 142929

Screenshot 2022-09-02 114253

Other information

Closes #1368.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 1, 2022
@francescospissu francescospissu marked this pull request as ready for review September 2, 2022 12:58
@AlbyIanna AlbyIanna self-requested a review September 7, 2022 13:25
AlbyIanna
AlbyIanna approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kittaakos
kittaakos suggested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the buttons are in the correct position. I have checked:

  • new sketch file,
  • 3rd party URLs, and
  • install lib with dependencies.

I found a problem:

invalid_filename.mp4

@francescospissu
Copy link
Contributor Author

Thanks for the feedback @kittaakos, I moved the close button before the last child (primary button), now it appears like this:

image

This was the older behavior:

image

@kittaakos kittaakos mentioned this pull request Sep 16, 2022
Closed
3 tasks
@kittaakos kittaakos self-requested a review September 19, 2022 16:26
kittaakos
kittaakos approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Thank you!

verify_1382.mp4

@AlbyIanna AlbyIanna mentioned this pull request Sep 20, 2022
Merged
4 tasks
@francescospissu francescospissu merged commit 364f8b8 into main Sep 20, 2022
@francescospissu francescospissu deleted the fspissu/primary-buttons-position branch September 20, 2022 09:48
@per1234 per1234 mentioned this pull request Oct 2, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align the primary button in all dialogs in IDE
4 participants
@francescospissu @kittaakos @AlbyIanna @per1234